Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cargo.lock and add vscode to gitignore #1404

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Update cargo.lock and add vscode to gitignore #1404

merged 3 commits into from
Aug 25, 2023

Conversation

zyfjeff
Copy link
Contributor

@zyfjeff zyfjeff commented Aug 24, 2023

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

  1. Update cargo.lock to latest
  2. Add vscode to gitignore for all contrib subdir

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@zyfjeff zyfjeff requested a review from a team as a code owner August 24, 2023 13:16
@zyfjeff zyfjeff requested review from imeoer, adamqqqplay and hsiangkao and removed request for a team August 24, 2023 13:16
@zyfjeff zyfjeff changed the title Fix cargo Update cargo.lock and add vscode to gitignore Aug 24, 2023
@anolis-bot
Copy link
Collaborator

@zyfjeff , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90001

@anolis-bot
Copy link
Collaborator

@zyfjeff , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90002

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1404 (832774b) into master (156ba6a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
- Coverage   46.45%   46.44%   -0.02%     
==========================================
  Files         123      123              
  Lines       38602    38602              
  Branches    38602    38602              
==========================================
- Hits        17934    17928       -6     
- Misses      19697    19702       +5     
- Partials      971      972       +1

see 3 files with indirect coverage changes

imeoer
imeoer reviewed Aug 25, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@anolis-bot
Copy link
Collaborator

@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90161

@adamqqqplay
Copy link
Member

Need squash.

@zyfjeff
Copy link
Contributor Author

zyfjeff commented Aug 25, 2023

/retest

@anolis-bot
Copy link
Collaborator

@zyfjeff , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90171

@anolis-bot
Copy link
Collaborator

@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90173

@imeoer imeoer merged commit 1abf0ae into dragonflyoss:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@adamqqqplay adamqqqplay Awaiting requested review from adamqqqplay adamqqqplay is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
anolis_testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zyfjeff @anolis-bot @adamqqqplay @imeoer